trinodb/trino

LDAP password auth - only first 1000 users are searched against

Open

#2,359 opened on Dec 28, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (9,113 stars) (2,678 forks)batch import
good first issue

Description

LDAP authentication with a search returning > 1000 results will not find some users in ActiveDirectory as only first 1000 results are returned.

https://stackoverflow.com/a/33445705/8874837 http://stackoverflow.com/a/31750628/384674 https://stackoverflow.com/questions/30567983/query-to-ad-for-unlimited-results https://stackoverflow.com/questions/58638194/how-to-fix-ldap-connection-error-javax-naming-sizelimitexceededexception-ldap https://self-learning-java-tutorial.blogspot.com/2016/06/jndi-pagination-support.html https://docs.oracle.com/javase/7/docs/api/javax/naming/ldap/PagedResultsControl.html can resolve this

Contributor guide

Tech stack
java
Domain
backendauthentication
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaLDAPTrino build process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the LDAP authentication code in Trino (likely in the 'trino main' module). The issue is that the LDAP search does not handle pagination. Refer to the provided links on how to implement PagedResultsControl (javax.naming.ldap.PagedResultsControl). Search for the existing LDAP search implementation and modify it to use pagination. Also check if there are any existing tests for LDAP authentication.