trinodb/trino

Refactor `testTimestampCoercion*` in Delta Lake connector

Open

#22,042 opened on May 21, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Java (9,113 stars) (2,678 forks)batch import
delta-lakegood first issue

Description

We should introduce TypeCoercionTestSetup record which is used in BaseIcebergConnectorTest. Also, nested types (e.g. array(array(...))) should be tested after the refactoring.

Contributor guide

Tech stack
java
Domain
testingbackend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaTrino testing framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the current testTimestampCoercion tests in the Delta Lake connector to understand the pattern. Then create a TypeCoercionTestSetup record similar to the one used in BaseIcebergConnectorTest. After refactoring, ensure nested array types are also tested. Look at the existing test structure and the Iceberg connector test setup for reference.