trinodb/trino

Do not override docker image configuration in testing images

Open

#1,978 opened on Nov 7, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (9,113 stars) (2,678 forks)batch import
good first issue

Description

Example, one image provides hadoop and so it contains core-site.xml, then that image is used as base for another image (with some additional feature like KRB) and then it overrides core-site.xml. This approach makes it very unclear what actually has changed between these images.

One idea to fix this is to use apply-site-xml-override.sh from https://github.com/prestosql/presto/pull/1958#discussion_r343593949

Contributor guide

Tech stack
javadockershell
Domain
devopstestinginfrastructure
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Dockershell scriptingHadoop configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Study the referenced PR (https://github.com/prestosql/presto/pull/1958) and the `apply site xml override.sh` script. Then identify Dockerfiles in the trinodb/trino testing images that currently override `core site.xml` and replace the override with the script approach. Ensure all changes are made across relevant base and derived images to maintain clarity.