trinodb/trino

Add test coverage for blackhole connector

Open

#18482 opened on Aug 1, 2023

View on GitHub
 (6 comments) (0 reactions) (1 assignee)Java (9,113 stars) (2,678 forks)batch import
good first issuetest

Description

During work on this PR https://github.com/trinodb/trino/pull/18016, noticed that test coverage is pretty small. I think we could refactor current Smoke test to be more consistent with BaseConnectorSmokeTest. And think about BaseConnectorTest

Contributor guide

Tech stack
java
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaBasic understanding of Trino connectorsFamiliarity with test refactoring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the linked PR (https://github.com/trinodb/trino/pull/18016) to understand the current blackhole connector smoke test. Examine the existing BaseConnectorSmokeTest and BaseConnectorTest classes in the Trino repository to understand the expected patterns. Identify gaps in test coverage and propose a refactoring plan. Engage with maintainers on the issue to clarify the scope and preferred approach before coding.