trezor/definitions

Check and clip threshold values.

Open

#85 opened on Aug 12, 2026

View on GitHub
 (0 comments) (1 reaction) (1 assignee)Python (7 forks)github user discovery
enhancementerc7730ethereumgood first issue

Repository metrics

Stars
 (3 stars)
PR merge metrics
 (Avg merge 5d 11h) (8 merged PRs in 30d)

Description

The spec says the values should be ABOVE the threshold, but practically it is above OR EQUAL. This might be updated as well: https://github.com/ethereum/clear-signing-erc7730-registry/issues/2863

We can keep a track of it, but until then, we could consider clipping and logging a field's max value to MAX_VALUE - 1 in the definition itself to avoid errors.

It is not a priority since this merged: https://github.com/ethereum/clear-signing-erc7730-registry/pull/2870 but would be good to have.

OR

fixed in Firmware.

Contributor guide

Research direction
Examine the threshold validation logic in the definitions repository, identify where equality is allowed instead of strict greater than, and consider clipping the field's maximum value to MAX VALUE 1 or aligning with firmware behavior.
Tech stack
python
Domain
blockchainbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60