trailofbits/manticore

Manticore fails to capture Executor failure in status code

Open

#770 opened on Feb 23, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (3,469 stars) (481 forks)batch import
good first issuehelp wanted

Description

@mossberg

I find it mildly unsatisfying that if Manticore crashes while in the executor loop, the process will still return 0 (meaning subprocess.check_output or check_call will not catch it). But that's an issue for a later time.

Contributor guide

Tech stack
python
Domain
backendsecurity
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonManticore's executor loop
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the executor loop in Manticore, likely in the main execution file (e.g., manticore/core/executor.py). Determine where the process exit code is set and ensure that exceptions during the executor loop result in a non zero exit code. Look at the main entry point and how it catches exceptions. There is no linked PR or assignee, so this is open for research. The issue was reported in 2018, so check the current codebase for changes.