trailofbits/manticore

Manticore fails to capture Executor failure in status code

Open

#770 opened on Feb 23, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (481 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (3,469 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

@mossberg

I find it mildly unsatisfying that if Manticore crashes while in the executor loop, the process will still return 0 (meaning subprocess.check_output or check_call will not catch it). But that's an issue for a later time.

Contributor guide

Research direction
Inspect the executor loop in Manticore to see how it sets the exit code. Ensure that when an exception occurs, the process exits with a non zero status code instead of 0.
Tech stack
python
Domain
backendtesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Pythonsubprocess
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40