trailofbits/manticore

Feature request: Automatic conversion of tx.return_data

Open

#1595 opened on Jan 23, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (3,469 stars) (481 forks)batch import
ethereumhelp wantedidea

Description

Currently, to retrieve the return value of a transaction, we need to do

    balance_raw = transaction.return_data
    balance = ABI.deserialize("uint", balance_raw)

It would be nice to have a transaction's property that deserializes automatically the data, given the function's signature.

Contributor guide

Tech stack
python
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Manticore's transaction APIKnowledge of ABI encoding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Transaction class in Manticore's source code, specifically the return data attribute and how ABI.deserialize works. Consider adding a new property that takes an optional ABI signature and returns the deserialized value. Evaluate impact on existing tests.