trailofbits/manticore

Refactor/unify repetitive pattern

Open

#1059 opened on Aug 16, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (3,469 stars) (481 forks)batch import
ethereumhelp wantedresearch

Description

This pattern comes up pretty regularly (in Solver.get_all_values, Solver.get_value, ConstraintSet.migrate), should we make a Expression.clone() ?

                if isinstance(foreign_var, Bool):
                    new_var = self.new_bool(name=migrated_name)
                elif isinstance(foreign_var, BitVec):
                    new_var = self.new_bitvec(foreign_var.size, name=migrated_name)
                elif isinstance(foreign_var, Array):
                    # Note that we are discarding the ArrayProxy encapsulation
                    new_var = self.new_array(index_max=foreign_var.index_max, index_bits=foreign_var.index_bits, value_bits=foreign_var.value_bits, name=migrated_name).array

Contributor guide

Tech stack
python
Domain
developer experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Review the repetitive pattern in Solver.get all values, Solver.get value, and ConstraintSet.migrate. Propose and implement a clone method on Expression classes to encapsulate the type checking and variable creation logic, then update all instances to use the new method. Check for any other occurrences of this pattern in the codebase.