traex/RippleEffect

Not working with onItemTouchListener

Open

#40 opened on Feb 9, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (1,097 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,938 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have added a custom onItemTouchListener for reacting to touch events,that works well but ripple effect is all gone.Is there some sort of conflict between these two??I am pretty new to android so please dont mind if i am missing something really easy

Contributor guide

Research direction
Investigate how Android touch events propagate through ViewGroups. The onItemTouchListener likely consumes the touch event, preventing the RippleDrawable from receiving it. Look into returning false from onInterceptTouchEvent or using setOnTouchListener with proper handling to allow the ripple effect.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Android basicsTouch event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60