toeverything/AFFiNE

[Feature Request]: Modify the interaction for attachment block

Open

#10781 opened on Mar 12, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (68,392 stars) (4,850 forks)batch import
help wantedstory

Description

Description

Change the interaction of the attachment block so that the toolbar is displayed only when selected, instead of on hover. When selected, the primary color border will appear and the background color need to be removed, same as the linked doc block style. This applies to both card view and embed view.

https://github.com/user-attachments/assets/073dfaaa-50df-4f5e-91d5-07e07965d777

Use case

No response

Anything else?

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ReactUnderstanding of CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look for the attachment block component in the codebase, likely under packages/frontend/core/src/blocks/attachment. Examine how the toolbar is currently displayed (on hover) and how the linked doc block handles selection. The desired change is to show the toolbar only when the block is selected, add a primary color border, and remove the background color. Test in both card and embed views.