tobgu/pyrsistent

PMap values, keys, and items should be iterables in Python 3

Open

#159 opened on Mar 29, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (1,943 stars) (141 forks)batch import
enhancementgood first issuehelp wanted

Description

Currently they wrap them into pvector which is not as efficient as it could be in Python 3.

Contributor guide

Tech stack
python
Domain
data
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Python 3 knowledgepyrsistent internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests making PMap.keys(), .values(), and .items() return proper iterables instead of wrapping results in pvector. The current implementation is in the source file for PMap, likely in pyrsistent/ pmap.py. The contributor should examine the methods and understand how to return view objects or generators. The 3 comments may contain hints, but are not shown here. No linked PRs exist, so the work is still open.
PMap values, keys, and items should be iterables in Python 3 · tobgu/pyrsistent#159 | Good First Issue