Add quotes around format strings for compatibility with msys2 (git bash)

Open Beginner friendly
#745 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
bash, python
Domain
cli

Research direction

Start with the attached msys2-compatibility-quoting.patch and reproduce the hang from tmux list-sessions in an MSYS2 or Git Bash shell. Check the three-line quoting change against the affected format-string commands, then verify the commands work there and do not regress on other platforms.

Written by the indexing model from the issue text.

Description

Basic commands such as tmux list-sessions currently hang when running in an msys2 shell (ie.g., git bash). For some reason, this can be resolved by adding quotes around the format strings. A 3-liner patch is attached. Have not tested this change on other platforms, and also have not thoroughly tested for additional cases where quotes may be necessary for msys2 compatibility.

msys2-compatibility-quoting.patch

Dominant language
Python
Stars
1.2k
Forks
127
Avg merge
2h 13m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tmux-python/libtmux

All issues in tmux-python/libtmux

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.