tmspzz/Rome

Reduce code duplication in some function

Open

#51 opened on Mar 24, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (771 stars) (54 forks)batch import
help wantedready-to-implement

Description

Enhancement Suggestion

Reduce code duplication in some function.

Steps which explain the enhancement

Example of function which could use some slimming down

Current and suggested behavior

Currently there are tiny differences which lead to a ton of duplication. A more careful design can reduce code duplication.

Why would the enhancement be useful to most users This enhancement does nothing for the users but a lot for code quality and maintenance

Contributor guide

Tech stack
None
Domain
build systemdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Haskell knowledgefamiliarity with Lib.hs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Examine the two functions in Lib.hs (lines 290 and 325) to identify shared logic and differences. Propose a refactoring that extracts common functionality into a helper function. The issue is from 2017 with no maintainer feedback, so ensure any changes align with the project's coding style. Consider discussing the approach in the issue before implementing.
Reduce code duplication in some function · tmspzz/Rome#51 | Good First Issue