tmspzz/Rome

Add Tests for some simple funcions

Open

#27 opened on Oct 2, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Haskell (771 stars) (54 forks)batch import
good first issuehacktoberfest

Description

Tests are currently lacking in the project. While some functions are harder to tests there are a few low hanging fruits.

Steps which explain the enhancement

By using QuickCheck add more tests

Tests should reside in the tests directory

Current and suggested behavior

No changes to the application's behaviour

Why would the enhancement be useful to most users

This change would enhance the confidence in the code base

Rome version: v0.6.0.10 OS and version: MacOSX 10.11.6 - El Capitan

Contributor guide

Tech stack
None
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Haskell basicsQuickCheck
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the test directory at https://github.com/blender/Rome/tree/master/test for existing test structure. Identify simple functions in the codebase that are not yet tested. Use QuickCheck to write property based tests for those functions. Refer to the QuickCheck documentation for guidance on writing test cases. Ensure tests are placed in the appropriate test files.