tmspzz/Rome

Should not print error if the file attempting to delete does not exist for `bcsymbolmap`

Open

#209 opened on Jan 13, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Haskell (771 stars) (54 forks)batch import
enhancementhelp wanted

Description

When doing the first download, it seems like the "Delete of the bcsymbolmap" causes an error to be printed.

Reproduction Steps:

  1. Create a Romefile with Alamofire
  2. Do the build, and upload the files.
  3. Do rome download

** Expected behavior** Will download the needed files and display:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip

Observed behavior:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap

It looks like in the line:

https://github.com/tmspzz/Rome/blob/3279870fcaac111df5f3a9fd03c10a45c063758c/src/Caches/S3/Downloading.hs#L182

It attempts to delete the file that exists. In the case that the file does not exist, it should just ignore it and not print and error.

Rome version: 0.23.1.61 OS and version: macOS Catalina

Contributor guide

Tech stack
None
Domain
backendclicloud
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Haskell basicsRome codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue points to src/Caches/S3/Downloading.hs line 182 where a file deletion occurs and prints an error if the file doesn't exist. Start by reading that file to understand the current deletion logic. The fix is to either check if the file exists before deleting using `doesFileExist` or handle the specific error case. Ensure to maintain backward compatibility. After making the change, test with the reproduction steps provided in the issue.