0.17.0: pytest is failing
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- python
- Domain
- security, testing-qa
Research direction
Start with src/ecdsa/test_malformed_sigs.py, especially the list comprehension using hashlib.new(name) during test collection. Reproduce the pytest run in the reported Python 3.8 environment and inspect how unavailable algorithms such as whirlpool are handled. Done means test collection succeeds while the available hash algorithms remain covered.
Written by the indexing model from the issue text.
Description
I'm trying to package your module as an rpm package. So I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation- because I'm calling
buildwith--no-isolationI'm using during all processes only locally installed modules - install .whl file in </install/prefix>
- run pytest with PYTHONPATH pointing to sitearch and sitelib inside </install/prefix>
Here is pytest output:
+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-ecdsa-0.17.0-5.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-ecdsa-0.17.0-5.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/python-ecdsa-python-ecdsa-0.17.0
plugins: hypothesis-6.36.0
collected 1464 items / 1 error / 1463 selected
================================================================================== ERRORS ==================================================================================
____________________________________________________________ ERROR collecting src/ecdsa/test_malformed_sigs.py _____________________________________________________________
/usr/lib64/python3.8/hashlib.py:157: in __hash_new
return _hashlib.new(name, data)
E ValueError: [digital envelope routines] initialization error
During handling of the above exception, another exception occurred:
src/ecdsa/test_malformed_sigs.py:41: in <module>
hash_and_size = [
src/ecdsa/test_malformed_sigs.py:42: in <listcomp>
(name, hashlib.new(name).digest_size) for name in algorithms_available
/usr/lib64/python3.8/hashlib.py:163: in __hash_new
return __get_builtin_constructor(name)(data)
/usr/lib64/python3.8/hashlib.py:120: in __get_builtin_constructor
raise ValueError('unsupported hash type ' + name)
E ValueError: unsupported hash type whirlpool
========================================================================= short test summary info ==========================================================================
ERROR src/ecdsa/test_malformed_sigs.py - ValueError: unsupported hash type whirlpool
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================================================= 1 error in 1.17s =============================================================================
- Dominant language
- Python
- Stars
- 973
- Forks
- 343
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tlsfuzzer/python-ecdsa
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
tlsfuzzer/python-ecdsa#381 ·
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
tlsfuzzer/python-ecdsa#349 · 1 comment ·
-
feature help wanted
Difficulty 4/5 3-5 days Newbie friendliness 35/100
tlsfuzzer/python-ecdsa#348 · 1 comment ·
-
bug help wanted
Difficulty 3/5 1-2 days Newbie friendliness 35/100
tlsfuzzer/python-ecdsa#341 · 1 comment ·
-
Add type annotations Openmaintenance
Difficulty 5/5 Over a week Newbie friendliness 25/100
tlsfuzzer/python-ecdsa#340 · 4 comments · 1 reaction ·
All issues in tlsfuzzer/python-ecdsa
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100