tleunen/react-mdl

Menu items get broken after update

Open

#400 opened on Sep 19, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)CSS (1,772 stars) (259 forks)batch import
bughelp wanted

Description

I've created component that renders Menu with 3 items ['a', 'b', 'c'] from state. That works fine. Then I update component state items to ['a', 'x', 'y']. Component re-renders menu, but updated items are broken - they does not hide after click.

Please have a look on codepen for that: http://codepen.io/anon/pen/gwwKvk?editors=0011

Contributor guide

Tech stack
javascriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the Menu component implementation in react mdl to understand how items are rendered and event handlers are attached. The bug likely involves React's key reconciliation or state update not properly reinitializing menu item click handlers. Check the codepen example to reproduce the issue. Focus on the component's shouldComponentUpdate or componentDidUpdate lifecycle methods.