tleunen/react-mdl

Menu items get broken after update

Open

#400 opened on Sep 19, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)CSS (259 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,772 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've created component that renders Menu with 3 items ['a', 'b', 'c'] from state. That works fine. Then I update component state items to ['a', 'x', 'y']. Component re-renders menu, but updated items are broken - they does not hide after click.

Please have a look on codepen for that: http://codepen.io/anon/pen/gwwKvk?editors=0011

Contributor guide

Research direction
Examine the codepen example to understand the component structure. Focus on how the menu items are rendered (e.g., key props, event handlers) and why items fail to hide after state update. Check if the issue is related to missing key prop or improper component re rendering.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65