tisfeng/Easydict

馃殌 Feature Request: Favorite Languages

Open

#607 opened on Jul 11, 2024

View on GitHub
聽(18 comments)聽(8 reactions)聽(1 assignee)Swift聽(13,140 stars)聽(657 forks)batch import
enhancementgood first issue

Description

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page and didn't find a similar feature request.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Feature description

Hello everyone.

Thank you so much for the great app. I love it and I suggested it to my friends.

Every day I use English, Turkish, and German. So I need to switch between three languages. However, it is hard to find in the long list.

On the other hand, they are not alphabetically sorted in English.

It would be great to have a favorite language support in the settings.
So when we open the translate window we can only list:

  • Auto
  • First Language
  • Second Language
  • Favorite 1
  • Favorite 2
  • ...

I have already searched the issues, there was an issue about the "last languages on top". But I think this feature is more suitable.

Thank you all again. Have a nice day.

Use case

Every day I use English, Turkish, and German. So I need to switch between three languages. However, it is hard to find in the long list.

Proposed solution (optional)

It would be great to have a favorite language support in the settings.
So when we open the translate window we can only list:

  • Auto
  • First Language
  • Second Language
  • Favorite 1
  • Favorite 2
  • ...

Are you willing to submit a PR to implement this feature

  • I'm willing to submit PR

Contributor guide

Tech stack
swift
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
SwiftmacOS development basicsfamiliarity with Easydict codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the existing language selection UI in Easydict to understand how languages are listed and selected. Examine the settings implementation to see where a favorites list could be added. Consider the discussion in this issue and related issue #396 about 'last languages on top'. The proposed solution involves adding a user configurable favorites list in settings, and modifying the language picker to prioritize favorites. Implementation should be done in Swift, likely modifying Views related to language selection and storage.