tikv/tikv

De-duplicate dependencies

Open

#4149 opened on Jan 30, 2019

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Rust (15,922 stars) (2,189 forks)batch import
component/build-timehelp wantedstatus/mentor

Description

There are a number of duplicate dependencies in our crate graph, adding to compile times. cargo tree might help to find them. Eliminate a many as possible.

Create a whitelist of allowed dupes, and a CI script that checks it; to avoid regressions, and ensure we know when we're adding dupes.

Contributor guide

Tech stack
rust
Domain
build systemci cdperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustcargoCI basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
First, run `cargo tree` to identify duplicate dependencies in the crate graph. Then, analyze each duplicate to see if they can be consolidated or upgraded to a shared version. Create a whitelist of allowed duplicates (e.g., due to version incompatibilities) and add a CI script (e.g., in .github/workflows) that runs `cargo tree duplicates` and fails if any unauthorized duplicates are found. Refer to the existing CI configuration in the repository for patterns.