thunderbird/thunderbird-android

Ask for notification permission when enabling account notifications

Open

#7,554 opened on Jan 24, 2024

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Kotlin (13,479 stars) (2,734 forks)batch import
good first issuepriority: medium

Description

Currently the app is only asking for the notification permission during onboarding. But if the user doesn't grant the permission then, the app should ask again when the user enables notifications for an account (either when adding an additional account or via account settings).

We'll also have to handle the case where the user has denied the permission already and point them to the correct Android screen to reverse that decision.

Open question: What should the app do when it notices the notification permission has been revoked, but notifications are enabled inside the app?

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Android permission modelKotlinThunderbird Android codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate where notification permission is requested during onboarding (likely in onboarding flow). Find the account settings screen where notifications can be toggled (e.g., AccountSettingsFragment). Implement permission request when user enables notifications. Handle denied permission by showing rationale or directing to system settings. For the open question about revoked permissions, seek clarification from maintainers. Check existing permission handling in NotificationPermissionManager.