Two unbalanced {for} blocks in keyboard-shortcuts-thunderbird (lines 228, 308)
@rtanglao is already working on this.
Since Aug 4, 2026.
Assessment
This issue has not been assessed yet.
Description
Two unbalanced {for} blocks in Keyboard shortcuts - perform common Thunderbird tasks quickly.
Article: https://support.mozilla.org/en-US/kb/keyboard-shortcuts-thunderbird
Edit: https://support.mozilla.org/en-US/kb/keyboard-shortcuts-thunderbird/edit
These are worth flagging as a pair because the file's totals balance perfectly — 294 {for} against 294 {/for} — so counting tags finds nothing. One block has an extra closer and another is missing one, and the two cancel out. Only matching openers to closers in order reveals them.
1. Extra {/for} — line 228
|Tab 2 to 8||{for win}{key Ctrl+2}to{key 8}{/for}{for linux}{key Alt+2}to{key 8}{/for}{/for}{for mac}{key Command+2}to{key 8}{/for}
After the linux block closes there is a second {/for} with nothing open. Compare line 226, which has the same three-platform structure and is correct:
|Mail & Newsgroups Home Tab (Tab 1)||{for win}{key Ctrl+1}{/for}{for linux}{key Alt+1}{/for}{for mac}{key Command+1}{/for}
Fix: delete the duplicated {/for}.
2. Unclosed {for mac} — line 308
|Rewrap message text||{for win,linux}{key Ctrl+R}{/for}{for mac}{key Command+R}
The {for mac} block is never closed. Compare line 306, same shape, correct:
|Paste without formatting||{for win,linux}{key Ctrl+Shift+V}{/for}{for mac}{key Command+Shift+V}{/for}
Fix: append {/for}.
Likely user-visible effect
Both are inside a large {| table of keyboard shortcuts. An unbalanced platform block can leak content into the wrong platform's view or unbalance the surrounding table markup, so Mac or Linux readers may see shortcuts intended for another platform. I have not confirmed the exact rendered damage for these two, unlike #223–#225 — worth checking the rendered page before deciding how urgent this is.
Found by sumo-lint, the SUMO markup linter being built in
https://github.com/thunderbird/sumo-linter — rule SW001, which pairs {for}
openers with closers using a stack instead of counting them. Verified by hand
against the neighbouring correct lines.
- Dominant language
- No language data
- Stars
- 7
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from thunderbird/knowledgebase-issues
-
Desktop
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
Android M: Knowledge: Android
Difficulty 1/5 Under an hour Newbie friendliness 62/100
-
Android M: Knowledge: Android
Difficulty 2/5 1-2 days Newbie friendliness 68/100
-
modernization
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
thunderbird/knowledgebase-issues#231 · 1 assignee ·