thu-ml/tianshou

Include parts of atari/mujoco helpers in package code

Open

#988 opened on Nov 8, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (7,121 stars) (1,072 forks)batch import
good first issueminorrefactoring

Description

yeah sgtm, maybe in env/atari.py or utils/whatever.py?

Originally posted by @Trinkle23897 in https://github.com/thu-ml/tianshou/pull/970#discussion_r1374040740

Contributor guide

Tech stack
pythonpytorch
Domain
machine learningai
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonOpenAI Gym environmentsTianshou codebase layout
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Identify the existing atari and mujoco helpers in the repository (likely in environments or utils). Review the discussion in PR #970 (comment) to understand the required helpers. Determine the best location to add these helpers (env/atari.py or utils/). Implement and ensure consistency with existing code.