thu-ml/tianshou

Code duplication between ReplayBuffer and ReplayBufferManager

Open

#1,057 opened on Feb 16, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (7,121 stars) (1,072 forks)batch import
good first issuerefactoring

Description

Reduce the (significant) code duplication between ReplayBuffer and ReplayBufferManager

Contributor guide

Tech stack
pythonpytorch
Domain
machine learningbackend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Python programmingPyTorch basicsUnderstanding of Tianshou's replay buffer classes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the implementation of ReplayBuffer and ReplayBufferManager in the Tianshou library. Identify duplicated code patterns and consider extracting common functionality into a shared base class or helper functions. Review existing tests to ensure behavior is preserved. There are no linked PRs or comments to guide the approach.