thheller/shadow-cljs

Deno repl

Open

#923 opened on Aug 17, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Clojure (2,396 stars) (187 forks)batch import
help wanted

Description

I am trying to develop an application with clojurescript and deno. The trivial sources are here. It works great until I tried to run a repl.

To run the repl, I..

  1. Run the shadow-cljs repl via node_modules/.bin/shadow-cljs clj-repl
  2. The I start the deno repl using a command such as 
    (shadow/node-repl {:build-id :app ;; my application
               :node-command "/home/didier/.bin/deno"  ;; the deno bin directly 
               :node-args ["repl"]  ;; `deno repl` is very similar to `node`
               :verbose true})

Result: The underlying deno program exit and I have the following error.

[2021-08-17 16:59:18.741 - INFO] :shadow.cljs.devtools.server.repl-impl/node-repl-exit - {:code 0}

Expected: The repl should switch to deno process.

My two cents..

I believe the stdin of the deno process is closed. If I manually tail -f main.js | deno repl it works.

Contributor guide

Tech stack
javascriptdeno
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ClojureScript knowledgeshadow cljs basicsDeno basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate how shadow cljs spawns the Node REPL process via `shadow/node repl` and adapt it for Deno. The likely cause is that stdin is not properly piped to the Deno process. Check the source file `shadow.cljs.devtools.server.repl impl` for the child process spawning logic and ensure stdin is inherited or connected when the command is Deno.