theforeman/foremanctl

Review dynflow-sidekiq exec command

Open

#72 opened on Jan 29, 2025

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (38 forks)auto 404
foremangood first issue

Repository metrics

Stars
 (25 stars)
PR merge metrics
 (PR metrics pending)

Description

Based on https://github.com/evgeni/talks/pull/4#discussion_r1932083989 we should review the command:

https://github.com/theforeman/foreman-quadlet/blob/177348fc149e74a4adb6680cb239181f16cf8476/roles/foreman/tasks/main.yaml#L90

This copies the DYNFLOW_SIDEKIQ_SCRIPT (that's also set as an env var) and hardcodes the Rails environment, but do we even need to expose this in the first place? It's based on https://github.com/theforeman/foreman/blob/74ddd8851cebd21c268002e0c82a3619d2a9db66/extras/systemd/dynflow-sidekiq%40.service#L12-L20 but is it better to provide a better /usr/libexec/foreman/sidekiq-selinux wrapper script that has these defaults built in?

Contributor guide

Research direction
Compare the command in foreman quadlet with the upstream systemd service file. Evaluate if the DYNFLOW SIDEKIQ SCRIPT env var and hardcoded Rails environment are necessary. Consider creating a wrapper script in foremanctl that includes defaults.
Tech stack
pythonshell
Domain
backenddevops
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70