thedevdojo/voyager

BREAD Field labels have wrong for attribute

Open

#4247 opened on Jul 6, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wanted

Description

Version information

This is a code issue / error. It is present on the current "master" branch (1.2)

Description

The form label for attribute is not matched with the name field attribute. It is hardcoded: https://github.com/the-control-group/voyager/blob/7835b366babf63940aef18e52615852eb17e2651/resources/views/bread/edit-add.blade.php#L72

This is my suggestion/fix. <label class="control-label" for="{{ $row->field }}">{{ $row->display_name }}</label>

If you prefer a PR just ask.

Expected behavior

Labels should be matched with the corect form field.

Contributor guide

Tech stack
phplaravel
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic HTMLLaravel basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is in the file resources/views/bread/edit add.blade.php at line 72. The label's 'for' attribute is hardcoded to 'name', but should use {{ $row >field }} to match the input field's name attribute. A one line change is suggested. The issue has been open since 2019 with no assignee or linked PR, so it is available for contribution.