thedevdojo/voyager

[BUG] belongsToMany Relationship, Allow Tagging, and Custom URL Slugs

Open

#4128 opened on May 9, 2019

View on GitHub
 (1 comment) (4 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wantedtype:bug

Description

Version information

  • Laravel: v5.7.28
  • Voyager: v1.2.3
  • PHP: 7.2
  • Database: MySQL 5.7.25

Description:

When a relationship has tagging enabled and the BREAD for the other table has a custom slug a route not defined error is thrown.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Create belongsToMany relationships
  2. Create BREAD with custom "URL Slugs"
  3. Add relationship and Allow Tagging
  4. Go to the Add or Edit page of the BREAD with the relationship

Expected behavior

The add and edit page to load.

Additional context

vendor/tcg/voyager/resources/views/formfields/relationship.blade.php:159

When I looked at the relationship blade file the route is created off the table name when tagging is on. And the route for the relationship is a custom slug.

@if(isset($options->taggable) && $options->taggable == 'on')
    data-route="{{ route('voyager.'.\Illuminate\Support\Str::slug($options->table).'.store') }}"
    data-label="{{$options->label}}"
    data-error-message="{{__('voyager::bread.error_tagging')}}"
@endif

Contributor guide

Tech stack
phplaravel
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Laravel basicsVoyager BREAD understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the blade file at vendor/tcg/voyager/resources/views/formfields/relationship.blade.php line 159. The route is generated from the table name but should use the custom slug from the relationship options. Look at how routes are registered in Voyager to find the correct route name using the slug. Modify the data route attribute accordingly.