thedevdojo/voyager

Add fit features for images

Open

#3590 opened on Sep 28, 2018

View on GitHub
 (6 comments) (1 reaction) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wantedtype:enhancement

Description

We've got an option to crop, resize and upsize an image. However, not always it's possible to predict in what orientation the user will upload an image so that rules resize: 300x300 and crop: 300x300 will result in either square image or rectangle because an image is landscape-oriented. Therefore there is a need in fit like in Intervention/Image so that it will be needed size always. Please, consider to add this option to image fields.

Contributor guide

Tech stack
phplaravel
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PHPLaravelImage manipulation concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding a 'fit' feature to image fields, similar to Intervention Image's fit method. Start by examining existing image handling code in Voyager, likely in the BREAD or media manager controllers (e.g., app/Http/Controllers/VoyagerBreadController.php). Review the current resize and crop implementations to understand the pattern. Check the Intervention Image documentation for the fit method. Then propose adding a new option (e.g., 'fit') to the image field configuration and implement it by calling the Intervention fit method with appropriate parameters. Consider backwards compatibility and whether the new option should override or complement resize/crop. The maintainers may prefer a specific implementation approach, so a discussion in the issue would be beneficial before coding.