thedevdojo/voyager

Validation connected to Settings

Open

#3494 opened on Aug 25, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wanted

Description

  • Laravel: latest
  • Voyager: latest
  • PHP: 7
  • Database: mysql

Description of problem

Not really a problem, its a feature request.

Proposed solution

n/a

Alternatives considered

n/a

Additional context

As asked here it would be great to have the same validation currently available for Bread also for Settings, this is because you might have users that have to set a number as a settings but turn on adding invalid characters upon setting their settings.

For example we choose a textarea where a customer should typ only numbers, but instead the customer (user) is using text and therefore the input is invalid but did get accepted by the system.

It would be awesome to be able to set de validation variables also for the settings page.

Contributor guide

Tech stack
phplaravelmysql
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Laravel validationUnderstanding of Voyager's BREAD systemVoyager development environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine Voyager's BREAD validation implementation in VoyagerBreadController.php to understand how validation rules are applied. Then, locate the Settings controller (likely VoyagerSettingsController.php) and identify where settings are saved. Add validation logic similar to BREAD, allowing validation rules to be defined for each setting. Check if the settings table has a column for validation rules (e.g., 'validation') and how those rules are used. There is no linked PR or further discussion, so implementation details are open. Consider also reviewing any existing tests for settings to ensure backward compatibility.