thedevdojo/voyager

MenuItemPolicy fails with edit page urls

Open

#3443 opened on Aug 3, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wantedtype:enhancement

Description

Version information

  • Laravel: v5.6
  • Voyager: v1.1.3
  • PHP: 7.2

Description

When a route with parameters or a static url which include more than 1 segment added to admin menu, policy fails to check permission because slug fetched wrong (like pages1edit instead of pages)

Contributor guide

Tech stack
php
Domain
backendauthorization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHPLaravelVoyager admin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the MenuItemPolicy class (likely in app/Policies or within the Voyager package) to understand how the slug is extracted from the admin menu URL. Focus on the method that splits the URL segments; it may be incorrectly concatenating segments when there are multiple segments. Check the Voyager repository for any similar bug fixes or comments. Also review the issue comments for any additional context.