thedevdojo/voyager

MenuItemPolicy fails with edit page urls

Open

#3,443 opened on Aug 3, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PHP (2,652 forks)batch import
help wantedtype:enhancement

Repository metrics

Stars
 (11,817 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Version information

  • Laravel: v5.6
  • Voyager: v1.1.3
  • PHP: 7.2

Description

When a route with parameters or a static url which include more than 1 segment added to admin menu, policy fails to check permission because slug fetched wrong (like pages1edit instead of pages)

Contributor guide

Research direction
Review the MenuItemPolicy class and trace how the slug is derived from the route URL. Focus on the logic that extracts the slug when the URL contains multiple segments or parameters. Write a test to confirm the bug and then adjust the slug extraction to correctly identify the menu item slug.
Tech stack
phplaravel
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPLaravel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75