thedevdojo/voyager

Adding timestamps and soft deletes from table builder causes error

Open

#3364 opened on Jun 29, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wantedopen for suggestionstype:enhancement

Description

Version information

  • Laravel: v5.6.26
  • Voyager: v1.1.3
  • PHP: 7.2.7
  • Database: SQLite3 v3.11.0

Description

When creating a new table from within the Voyager control panel, then using the "+ Add timestamps" and "+ Add soft deletes" buttons results in an error that "timestamp" is not a valid datatype. The "timestamp" type is also not selectable in the drop-down menu, and other tables use a "datetime" field instead.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Menu > Tools > Database > Create new'
  2. Click on either the "+ Add timestamps" or "+ Add soft delete"
  3. Error message should appear in the top-right. The data types default to "time" instead.

Expected behavior

Since SQLite3 does not internally support timestamps, auto-select another default value that does work, for example "datetime" as the other generated tables are set to.

Additional context

This application is only using an SQLite3 database in the development environment.

Contributor guide

Tech stack
phplaravelsqlitesql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHP basicsLaravel structureSQLite syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the table builder code in Voyager that handles adding timestamps and soft deletes. The issue is that it defaults to 'timestamp' type, which SQLite does not support. Look for the controller or model responsible for generating the migration schema. Consider adding a conditional check for SQLite driver and automatically selecting 'datetime' instead. The fix might be in the BREAD builder or the DatabaseManager class.