thedevdojo/voyager

Rtl version problems

Open

#3084 opened on Apr 28, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wantedtype:enhancement

Description

  • Laravel Version: 5.6
  • Voyager Version: 1.1.0
  • PHP Version: 7.2.5
  • Database Driver & Version: mysql

Description:

Hi, i installed voyager and found that in new version the rtl version is included in the main package, but it is not documented anywhere. And after searching in sources i found that i must edit the voyager config file !

Project is good and the way to switch between rtl and ltr, but there is many issues in the rtl version.

  • One important issue for me is that dropdown in the left top doesn't works. it is set to display none and by clicking the icon, property not change.
  • Also i have no idea how to use my own local files to translate the voyager strings.
  • Theme is not responsive, i mean its layout breaks in small window size.
  • some icons do not move to the right of texts in rtl

I can help on improving the rtl version but don't know where to start. Thanks.

Contributor guide

Tech stack
phpjavascriptcss
Domain
frontendbackendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Laravel knowledgeCSS stylingJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Voyager configuration file (voyager.php) to understand how RTL mode is toggled. Examine the dropdown component's JavaScript and CSS files, likely in the public/assets/js and public/assets/css directories, to identify why the dropdown remains display:none on click. Check for any existing pull requests or issues related to RTL fixes. Consider testing with a fresh Laravel 5.6 installation and Voyager 1.1.0 to reproduce the issue.