thedevdojo/voyager

No Belongs-To-Many relation to current model in BREAD

Open

#2,193 opened on Nov 8, 2017

View on GitHub
 (2 comments) (5 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wantedopen for suggestionstype:enhancement

Description

  • Laravel Version: 5.5.20
  • Voyager Version: 1.0
  • PHP Version: 7.1.8
  • Database Driver & Version: MySQL 5.6.35

Description:

I would like to create a "belongs-to-many" relation from article to article which is called "related articles".

When I try to do this I can choose a pivot table but the system automatically chooses the keys for the relation. In this case it tries to use twice article_id as keys which is obviously not possible.

The fix would be to allow users to customize the key names which should be used inside of the pivot.

Steps To Reproduce:

  • Create a database table "test"
  • Create a database table "related_tests" with test_id and related_id as columns
  • Create a bread for this table
  • Add relationship
  • Choose belongs to many with test as target
  • Choose related_tests as pivot

Contributor guide

Tech stack
phplaravel
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Laravel EloquentVoyager BREAD configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the Voyager BREAD relationship creation code, particularly how belongs to many relationship keys are assigned. Identify where the pivot key names are hardcoded for self referencing relations. Look at comments on the issue for any suggested approach. Propose adding input fields for foreign key and local key in the relationship form, and update the backend to use those values.