tgstation/TerraGov-Marine-Corps

Igniter-timer assembly duplication

Open

#5626 opened on Jan 1, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (189 stars) (899 forks)batch import
BugGood First issue

Description

Testmerges:

Reproduction:

Ok first time submitting a bug Set a timer to 1 min and start it then make it attachable and attach it to a igniter. On the ground should appear the items used to make the assembly and they can be made into another one and repeated a lot.

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic DM language knowledgeUnderstanding of game object assembly
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the igniter timer assembly code, likely found in code/game/objects/items/assemblies/ or similar. Look for where the timer's attach() proc handles detaching from the igniter. The bug suggests that when the assembly is made attachable, the components are duplicated on the ground. Check if there is a missing check or improper handling of the object's loc or contents when detaching.