testng-team/testng

Test Smell: it is not a good practice to write a return statement in the test case

Open

#2,797 opened on Aug 29, 2022

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Java (1,025 forks)github user discovery
good first issuelogging

Repository metrics

Stars
 (2,059 stars)
PR merge metrics
 (Avg merge 17h 43m) (7 merged PRs in 30d)

Description

Hi! I notice that you write a test case with a return statement. For example,

It is not a good idea to write the return statement in your test case based on the definition of the test case. So I would like to know if is it really a useful test case? And no assertion is in this test case. Maybe I think you should remove this test case from your test code. Thanks.

Contributor guide

Research direction
Identify the test file mentioned in the issue, locate the test case with a return statement and no assertions, then remove or refactor it to include proper assertions.
Tech stack
java
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaTestNG
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70