testcontainers/testcontainers-java

Add getMappedPort(Integer originalPort, InternetProtocol protocol)

Open

#554 opened on Jan 23, 2018

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Java (1,588 forks)batch import
good first issueresolution/acknowledgedtype/feature

Repository metrics

Stars
 (7,535 stars)
PR merge metrics
 (Avg merge 2d 17h) (2 merged PRs in 30d)

Description

It will just look so much nicer in my test than

genericContainer.getContainerInfo().getNetworkSettings().getPorts().getBindings().get(new ExposedPort(originalPort, protocol))[0].getHostPortSpec()

I think it has something to do with the law of demeter.

But in all fairness root cause is https://github.com/moby/moby/issues/4635

Contributor guide

Research direction
Examine the existing GenericContainer class and its getContainerInfo() method to understand how to add a getMappedPort method that wraps the chain of calls to retrieve the host port. Look at how ExposedPort and InternetProtocol are used. Implement a simple delegation method.
Tech stack
java
Domain
backendtesting qaapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75