testcontainers/testcontainers-java

Improve error messaging when no docker-machine VM exists

Open

#307 opened on Mar 3, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Java (7,535 stars) (1,588 forks)batch import
client/docker-machinehelp wantedresolution/acknowledgedresolution/somedaymaybetype/feature

Description

e.g. in the case where the docker-machine tool is found but there's no VM.

At present the logged error is quite unhelpful:

o.t.d.DockerClientProviderStrategy       :     DockerMachineClientProviderStrategy: failed with exception InvalidConfigurationException (Exception when executing docker-machine status default)

Contributor guide

Tech stack
java
Domain
backendtestingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaDocker basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the DockerMachineClientProviderStrategy class in the testcontainers java source code. The error message is thrown as an InvalidConfigurationException when executing 'docker machine status default'. Improve the error message to clearly indicate that no docker machine VM exists and suggest creating one with a command like 'docker machine create default'. The change is localized to that class and requires only modifying the exception message.