testcontainers/testcontainers-java

Support container_name in docker-compose file

Open

#2,472 opened on Mar 24, 2020

View on GitHub
 (12 comments) (15 reactions) (0 assignees)Java (1,588 forks)batch import
area/docker-composegood first issuehelp wantedresolution/somedaymaybe

Repository metrics

Stars
 (7,535 stars)
PR merge metrics
 (Avg merge 2d 17h) (2 merged PRs in 30d)

Description

docker-compose files which contain container_name are not supported and the creation of DockerComposeContainer fails due to IllegalStateException. This has been introduced in #1151 as a quick fix for unintuitive feedback. If I understand correctly, the option of an implementation was however not discarded, but postponed. This issue is now about the implementation.

Contributor guide

Research direction
Examine the current Docker Compose implementation in Testcontainers to understand how services and containers are parsed. Extend the parsing logic to support the 'container name' field, ensuring it works with existing functionality like network aliases and service naming. Consider the previous quick fix and ensure the new implementation does not reintroduce the original issue.
Tech stack
javadocker
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55