testcontainers/testcontainers-java

Support container_name in docker-compose file

Open

#2,472 opened on Mar 24, 2020

View on GitHub
 (12 comments) (14 reactions) (0 assignees)Java (7,535 stars) (1,588 forks)batch import
area/docker-composegood first issuehelp wantedresolution/somedaymaybe

Description

docker-compose files which contain container_name are not supported and the creation of DockerComposeContainer fails due to IllegalStateException. This has been introduced in #1151 as a quick fix for unintuitive feedback. If I understand correctly, the option of an implementation was however not discarded, but postponed. This issue is now about the implementation.

Contributor guide

Tech stack
javadocker
Domain
backendtesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Javatestcontainers internalsdocker compose format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding support for the `container name` field in docker compose files when creating a `DockerComposeContainer`. The current behavior throws an `IllegalStateException` due to a quick fix in issue #1151. To implement this, you need to locate the docker compose parsing logic in the testcontainers java codebase, likely in files like `DockerComposeContainer.java` or related parser classes. The implementation should handle `container name` by mapping it appropriately to the container setup. Review the discussion in this issue and #1151 for context. There are no existing PRs, so the solution is open for contribution.