tesseract-ocr/tesseract

Test suite depends on submodule instead of using gtest from distribution

Open

#2838 opened on Jan 1, 2020

View on GitHub
 (14 comments) (0 reactions) (0 assignees)C++ (74,090 stars) (10,622 forks)batch import
feature requesthelp wantedunit tests

Description

Looks like some files are missing in dist tar ball.

[tkloczko@barrel tesseract-4.1.1]$ make check
Making check in src/arch
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/arch'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/arch'
Making check in src/ccutil
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/ccutil'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/ccutil'
Making check in src/viewer
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/viewer'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/viewer'
Making check in src/cutil
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/cutil'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/cutil'
Making check in src/opencl
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/opencl'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/opencl'
Making check in src/ccstruct
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/ccstruct'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/ccstruct'
Making check in src/dict
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/dict'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/dict'
Making check in src/classify
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/classify'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/classify'
Making check in src/wordrec
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/wordrec'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/wordrec'
Making check in src/textord
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/textord'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/textord'
Making check in src/lstm
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/lstm'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/lstm'
Making check in src/ccmain
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/ccmain'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/ccmain'
Making check in src/api
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/api'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/src/api'
Making check in .
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1'
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1'
Making check in tessdata
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata'
Making check in configs
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata/configs'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata/configs'
Making check in tessconfigs
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata/tessconfigs'
make[2]: Nothing to be done for 'check'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata/tessconfigs'
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata'
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/tessdata'
Making check in doc
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/doc'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/doc'
Making check in unittest
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/unittest'
make  apiexample_test applybox_test baseapi_test  bitvector_test cleanapi_test colpartition_test commandlineflags_test dawg_test denorm_test  fileio_test heap_test imagedata_test indexmapbidi_test intfeaturemap_test intsimdmatrix_test lang_model_test layout_test ligature_table_test linlsq_test lstm_recode_test lstm_squashed_test lstm_test lstmtrainer_test loadlang_test mastertrainer_test matrix_test  normstrngs_test nthitem_test osd_test pagesegmode_test  paragraphs_test params_model_test progress_test qrsequence_test recodebeam_test rect_test resultiterator_test scanutils_test shapetable_test stats_test  stringrenderer_test tablefind_test tablerecog_test tabvector_test  textlineprojection_test tfile_test unichar_test unicharcompress_test unicharset_test validate_grapheme_test validate_indic_test validate_khmer_test validate_myanmar_test validator_test libgtest.la libgtest_main.la libgmock.la libgmock_main.la libabseil.la
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/unittest'
g++ -DHAVE_CONFIG_H -I. -I..  -O2 -DNDEBUG -DTESSBIN_DIR="\"/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1\"" -DLANGDATA_DIR="\"/home/tkloczko/rpmbuild/BUILD/langdata_lstm\"" -DTESSDATA_DIR="\"/home/tkloczko/rpmbuild/BUILD/tessdata\"" -DTESSDATA_BEST_DIR="\"/home/tkloczko/rpmbuild/BUILD/tessdata_best\"" -DTESTING_DIR="\"/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/test/testing\"" -DTESTDATA_DIR="\"/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/test/testdata\"" -DPANGO_ENABLE_ENGINE  -I../src/api -I../src/api -I../src/arch -I../src/ccmain -I../src/ccstruct -I../src/ccutil -I../src/classify -I../src/cutil -I../src/dict -I../src/display -I../src/lstm -I../src/textord -I../unittest/base -I../unittest/util -I../src/training -I../src/viewer -I../src/wordrec -I../abseil  -isystem ../googletest/googletest/include -isystem ../googletest/googlemock/include -I/usr/include/leptonica     -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/harfbuzz  -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16   -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -std=c++17 -c -o apiexample_test.o apiexample_test.cc
make[2]: *** No rule to make target '../googletest/googletest/src/gtest-all.cc', needed by '../googletest/googletest/src/libgtest_la-gtest-all.lo'.  Stop.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/unittest'
make[1]: *** [Makefile:2656: check-am] Error 2
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/tesseract-4.1.1/unittest'
make: *** [Makefile:502: check-recursive] Error 1

Contributor guide

Tech stack
cpp
Domain
build systemtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ build experienceautotools (autoconf/automake)gtest dependency management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the build system configuration (configure.ac, Makefile.am) to detect whether Google Test is available as a system library. Update the configuration to allow using a system installed gtest instead of requiring the submodule. Ensure that the dist tarball can be built without the submodule by either bundling the required files or providing a fallback. Check existing comments for suggestions on how to handle this.