Consider reorganizing file layout to shorten path lengths
@rino20 is already working on this.
Since Jan 11, 2023.
Assessment
This issue has not been assessed yet.
Description
Describe the bug
The current package includes path names upwards of 150 characters such as default_8bit_cluster_preserve_quantize_scheme.py which are in turn relatively short files deep in a hierarchy. On Windows, the default limitation for paths is 260 characters as defined by MAX_PATH. While it is possible to modify this on a per-call basis, by default the Python ecosystem's tooling does not make this process simple for end users and there are a variety of tools still limited to the 260 character MAX_PATH. When you combine the path lengths of this repository with a location in a users' profile such as C:\Users\person-fullname\AppData\Local\Python\environments\deep-learning-environment\Lib\site-packages the limit can be exceeded.
Motivation
I work in a context where users can create environments in arbitrary locations and we want to use this package, the workaround we've found for the time being is to repack this repository as a Python egg and inject that into the environment at runtime, but would prefer to be able to use it as a direct Python dependency. Note that this limitation is specific to Windows, fortunately MacOS defaults to a MAXPATHLEN of 1024 and Linux values are typically 1024 or higher.
System information
TensorFlow version (installed from source or binary): All versions
TensorFlow Model Optimization version (installed from source or binary): All versions, specifically found working with v0.7.3.
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 349
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tensorflow/model-optimization
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
tensorflow/model-optimization#1301 · 1 comment ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
tensorflow/model-optimization#1272 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 50/100
tensorflow/model-optimization#1270 · 2 comments ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
tensorflow/model-optimization#1241 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
tensorflow/model-optimization#1182 · 1 comment ·
All issues in tensorflow/model-optimization
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
stephrobert/dsoxlab#238 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
sublimehq/package_control#1780 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nwg-piotr/nwg-displays#145 ·