log streaming does not terminate if a job is terminated while streaming logs

Open
#63 0 comments 0 reactions 1 assignee View on GitHub

@pavithrasv is already working on this.

Since Jul 17, 2020.

Assessment

This issue has not been assessed yet.

Description

bug

I started a job with log streaming enabled. While the job was running I manually terminated the job in AI Platform training by clicking on stop job in the UI. The log streaming continued to run after 5 minutes until manual termination with the following:

  File ".../cloud/tensorflow_cloud/deploy.py", line 211, in _stream_logs
    output = process.stdout.readline()

I expected when the job is terminated on AI Platform training the log streaming should also terminate / stop.

Dominant language
Python
Stars
383
Forks
93
Avg merge
1d 3h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tensorflow/cloud

All issues in tensorflow/cloud

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.