[Bug] Converter returns bad value converting `dict[None, Any]`

Open
#1,237 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start with the failing case in test_converter.py: ok(dict[None, str], {'null': "1"}). Reproduce the current result and inspect the converter behavior around this type. The issue is complete when the expected return object for dict[None, str] is agreed and the test passes with that result.

Written by the indexing model from the issue text.

Description

bug
What are you really trying to do?

I don't know why this would be a thing.

Describe the bug

In test_converter.py,
ok(dict[None, str], {'null': "1"}) passes, but that doesn't really seem like the correct return object.

Minimal Reproduction
Environment/Versions
  • OS and processor: [e.g. M1 Mac, x86 Windows, Linux]
  • Temporal Version: [e.g. 1.14.0?] and/or SDK version
  • Are you using Docker or Kubernetes or building Temporal from source?
Additional context
Dominant language
Python
Stars
1.2k
Forks
241
Avg merge
3d 2h
Merged PRs (30d)
49

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from temporalio/sdk-python

All issues in temporalio/sdk-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.