[Bug] Update Pydantic converter example to reflect `with_child_unrestricted` changes
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 55/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- documentation
Research direction
Open pydantic_converter/worker.py and read the TODO about using with_child_unrestricted after sdk-python issue 254 was fixed and released. Update the reference example to reflect that change, then verify the Pydantic converter example no longer relies on the workaround described in the issue.
Written by the indexing model from the issue text.
Description
What are you really trying to do?
I want to use Pydantic and datetime objects as input/outputs/signals/queries to workflows and activities.
Describe the bug
The recommended reference example for the Pydantic converter creates a new sandbox to work around a bug in Pydantic.
There is a TODO in the code below:
https://github.com/temporalio/samples-python/blob/main/pydantic_converter/worker.py
that says:
TODO(cretz): Use with_child_unrestricted when https://github.com/temporalio/sdk-python/issues/254 is fixed and released
The issue in question has now been merged but the example hasn't been updated.
Minimal Reproduction
https://github.com/temporalio/samples-python/blob/main/pydantic_converter/worker.py
Environment/Versions
n/a
Additional context
n/a
Thanks!
- Dominant language
- Python
- Stars
- 367
- Forks
- 121
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 11
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from temporalio/samples-python
-
enhancement
temporalio/samples-python#254 · 1 comment · 1 assignee ·
-
enhancement
temporalio/samples-python#253 · 1 assignee ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 45/100
temporalio/samples-python#231 · 1 comment ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
temporalio/samples-python#192 · 2 comments ·
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 45/100
temporalio/samples-python#191 ·
All issues in temporalio/samples-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100