tektoncd/pipeline

All exported functions must have unit test

Open

#6,364 opened on Mar 16, 2023

View on GitHub
 (9 comments) (0 reactions) (1 assignee)Go (1,943 forks)auto 404
area/testinggood first issuehelp wantedkind/cleanup

Repository metrics

Stars
 (9,013 stars)
PR merge metrics
 (PR metrics pending)

Description

As discussed in this PR https://github.com/tektoncd/pipeline/pull/6165#discussion_r1138710049, our standards restricts PR merges if an exported function does not have a unit test.

Let’s audit pipeline repo and make sure we comply to this standard across the board. Let’s check if an exported function has a unit test associated with it, if not, please add one.

/cc @jerop

Contributor guide

Research direction
Inspect each exported function (capitalized) in the Go codebase using 'grep' or 'go doc', and check if a corresponding unit test file exists with a test function (e.g., TestFunctionName). If missing, add a test following the pattern of existing tests in the same package.
Tech stack
go
Domain
devopstesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70