techgaun/ad-bs-converter

handle the argument input like NaN.bs2ad('2075/04/00')

Open

#6 opened on Aug 21, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (16 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (29 stars)
PR merge metrics
 (PR metrics pending)

Description

.bs2ad('2075/04/00') gives out the last month's converted date if possible, handle the way the input is received

like if('2018/02/31') is passed as an argument for ad2bs then, it also gives out result which is absurd because feb cant have 31 days

Contributor guide

Research direction
Add input validation to handle malformed date strings such as '2075/04/00' and '2018/02/31'. Check for invalid day/month values and return an error or default behavior.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75