tarantool/tarantool

Provide careful validation for box.schema.space.create() arguments

Open

#5,636 opened on Dec 17, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Lua (3,633 stars) (406 forks)batch import
featuregood first issueverbosity

Description

Now only memtx spaces can be temporary. Support of vinyl temporary spaces should be added in scope of #1785. However, now it is possible specify vinyl engine alongside with 'temporary' option:

box.schema.space.create('temp', {temporary=true}, {engine = 'vinyl'})
---
- engine: memtx
...

As one can see, vinyl engine is ignored and created space anyway uses memtx. I suggest to raise an error in this case in order to avoid misunderstanding.

Contributor guide

Tech stack
lua
Domain
databaseapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Lua programmingtarantool basicsspace creation options
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate the implementation of box.schema.space.create() in the tarantool source, likely in src/box/lua/schema.lua. Examine the current validation of engine and temporary options, especially how engine defaults to memtx when temporary is true. Add a check that raises an error when engine='vinyl' and temporary=true is specified, following existing error handling patterns in the same function.