tarantool/tarantool

Provide careful validation for box.schema.space.create() arguments

Open

#5,636 opened on Dec 17, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Lua (406 forks)batch import
featuregood first issueverbosity

Repository metrics

Stars
 (3,633 stars)
PR merge metrics
 (Avg merge 13d 2h) (82 merged PRs in 30d)

Description

Now only memtx spaces can be temporary. Support of vinyl temporary spaces should be added in scope of #1785. However, now it is possible specify vinyl engine alongside with 'temporary' option:

box.schema.space.create('temp', {temporary=true}, {engine = 'vinyl'})
---
- engine: memtx
...

As one can see, vinyl engine is ignored and created space anyway uses memtx. I suggest to raise an error in this case in order to avoid misunderstanding.

Contributor guide

Research direction
Examine the code where box.schema.space.create processes the 'engine' and 'temporary' options, likely in src/box/lua/schema.lua or similar, and add a check that raises an error if engine='vinyl' and temporary=true.
Tech stack
luac
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitLua
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60