register-as-service forces https

Open Beginner friendly
#236 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
go, kubernetes

Research direction

Trace the register-as-service startup path and how it handles the https setting when a service name is configured. Verify the behavior with https=false in service mode; done means the service starts without forcing HTTPS and supports the intended short-form HTTP URLs.

Written by the indexing model from the issue text.

Description

Hi all,
I've been running a single pod golink instance for a few years without problems.
I'm trying to switch over to using a service for a k8s deployment of golink, since that makes things a bit cleaner (better rollouts, less worries about pod starting and getting the right tailnet name)
To allow fully short form URLs I've been running golink as a plain http service. This allow URLs of the form http://go/things, so a user can just go/things.
Unfortunately, once you set the service name golink insists on starting as https, when running as https you have to use the fully qualified name for the certificate to work (the process logs invalid domain on getting an unqualified domain).
It looks fairly easy to respect https=false for the service case, but perhaps there's a reason it was not permitted originally?

Dominant language
Go
Stars
1.9k
Forks
145
Avg merge
9m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tailscale/golink

All issues in tailscale/golink

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.