new typescript actions creates artifacts in repo
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions, typescript
- Domain
- ci-cd
Research direction
Start by tracing the TypeScript action's creation of tailscale.tgz and tailscaled.pid, then inspect the repository .gitignore and the action runner's available XDG directories. Determine a suitable location outside the local repository for both artifacts, and verify that an action updating files can open a PR without including them.
Written by the indexing model from the issue text.
Description
The new typescript action creates artifacts in the local repo, the tailscale.tgz and tailscaled.pid files. In most cases, that's probably not a big deal, but for actions that are updating files in the local repo and then opening PRs, those files get included in the PR. For example, our internal http://go/golink-snapshot action. For now, I've added those to our .gitignore file, which is fine, but it might be nice to store those elsewhere if possible?
If you want to be really pedantic about it, tailscale.tgz should probably be put in XDG_CACHE_HOME (default: ~/.cache) and tailscaled.pid should be in XDG_RUNTIME_DIR, which I don't think has a canonical default. On my system, it's set to /run/user/1000, but that might be an arch thing. We might need to experiment with what gets set on action runners, or just simply putting it in ~/.cache too would likely be fine.
- Dominant language
- TypeScript
- Stars
- 938
- Forks
- 137
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tailscale/github-action
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
tailscale/github-action#283 · 1 comment · 1 reaction ·
-
fr
Difficulty 3/5 1-2 days Newbie friendliness 68/100
tailscale/github-action#317 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
tailscale/github-action#316 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
tailscale/github-action#315 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
tailscale/github-action#313 · 1 reaction ·
All issues in tailscale/github-action
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
fil-donadoni/tolaria#4409 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·