taichi-dev/taichi

[GGUI] Fix crash when certain keys are pressed.

Open

#3,254 opened on Oct 22, 2021

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C++ (28,195 stars) (2,384 forks)batch import
good first issueguipotential bug

Description

GGUI crashes when certain keys are pressed (The Windows key, for example).

Relevant code:

https://github.com/taichi-dev/taichi/blob/master/taichi/ui/common/input_handler.h https://github.com/taichi-dev/taichi/blob/master/taichi/ui/utils/utils.h

It would be great to support all of these keys, or at least add a try-catch to avoid the window from crashing.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Key event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the files at taichi/ui/common/input handler.h and taichi/ui/utils/utils.h. The issue suggests either adding a try catch to prevent crashes or expanding key support. Look for how the current key handling is implemented and consider implementing a try catch block for unhandled key codes. Alternatively, add mapping for missing keys (e.g., Windows key). Ensure that the fix does not break existing functionality. Check for any related comments in the issue for additional context.