taichi-dev/taichi

[GGUI] Fix crash when certain keys are pressed.

Open

#3,254 opened on Oct 22, 2021

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C++ (2,384 forks)batch import
good first issueguipotential bug

Repository metrics

Stars
 (28,195 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

GGUI crashes when certain keys are pressed (The Windows key, for example).

Relevant code:

https://github.com/taichi-dev/taichi/blob/master/taichi/ui/common/input_handler.h https://github.com/taichi-dev/taichi/blob/master/taichi/ui/utils/utils.h

It would be great to support all of these keys, or at least add a try-catch to avoid the window from crashing.

Contributor guide

Research direction
Examine the input handler.h and utils.h files to understand how key events are processed, then add missing key mappings or a try catch to prevent crashes.
Tech stack
python
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GUI programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60