swimlane/angular-data-table

Last record can't be close in grouping

Open

#81 opened on Sep 24, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (150 forks)batch import
bughelp wanted

Repository metrics

Stars
 (582 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi

If you open the last record in this example: http://codepen.io/marjan-georgiev/pen/JdMBMQ

you can't close it.

regards

Patrick

Contributor guide

Research direction
Reproduce the issue using the provided CodePen example. Investigate the grouping logic in the data table to understand why the last record cannot be closed. Look for any off by one errors or missing event handlers for the last record.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptangularGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80