swimlane/angular-data-table

Last record can't be close in grouping

Open

#81 opened on Sep 24, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (582 stars) (150 forks)batch import
bughelp wanted

Description

Hi

If you open the last record in this example: http://codepen.io/marjan-georgiev/pen/JdMBMQ

you can't close it.

regards

Patrick

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of AngularJSFamiliarity with data table grouping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Check the grouping functionality in the source code, likely in the AngularJS data table components. Look for event handlers related to opening/closing grouped rows. The bug might be due to an off by one error or missing event listener for the last record. Review the demo at the provided CodePen to reproduce the issue.